[PATCH] D53877: [IR] Strawman for dedicated FNeg IR instruction

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added inline comments.


================
Comment at: include/llvm-c/Core.h:141
+  LLVMCatchSwitch    = 66
 } LLVMOpcode;
 
----------------
cameron.mcinally wrote:
> Reordering these values appears to have exposed a bug in the MergeFunctions pass (*I think*). It seems that the hash accumulator can overflow with these larger numbers. Although, I could be mistaken.
> 
> @dyatkovskiy 
Ah, sorry. This was the wrong bit of code. Will correct...


================
Comment at: include/llvm/IR/Instruction.def:221
+  LAST_OTHER_INST(65)
 
 #undef  FIRST_TERM_INST
----------------
Reordering these values appears to have exposed a bug in the MergeFunctions pass (*I think*). It seems that the hash accumulator can overflow with these larger numbers. Although, I could be mistaken.

@dyatkovskiy


Repository:
  rL LLVM

https://reviews.llvm.org/D53877