[PATCH] D53852: [IR] Allow increasing the alignment of dso-local globals.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/IR/Globals.cpp:240-242
   // executable binary. (A COPY relocation is also generated, to copy
   // the initial data from the shadowed variable in the shared-lib
   // into the location in the main binary, before running code.)
----------------
rnk wrote:
> What about copy relocations? I think if you have some DSO a.so and a binary b.exe, b.exe could copy visible global variables from a.so into b.exe. Will it keep the alignment if it does?
A global variable defined in a shared library isn't dso_local.


Repository:
  rL LLVM

https://reviews.llvm.org/D53852