[PATCH] D53869: [NFC][compiler-rt] Cleanup Implicit Conversion Sanitizer tests to use sized types

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 11:03:34 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D53869#1280705, @filcab wrote:

> Looks good, thank you.




> Ideally, we'd have different names on those functions, but unless you have a script that generates this and is very easy to change,

It's super easy to change using mass search-and-replace, but i actually intentionally kept the *function names* as-is,
to be in sync with the clang codegen tests.

> I'm ok with keeping them as they are.
> 
> LGTM

Feel like actually marking these two reviews as accepted? :)

> Thanks for working on this!
> 
>   Filipe




Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53869





More information about the llvm-commits mailing list