[llvm] r345593 - [X86] Re-enable the machine verifier after fixing more tests

Francis Visoiu Mistrih via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 05:20:17 PDT 2018


Author: thegameg
Date: Tue Oct 30 05:20:17 2018
New Revision: 345593

URL: http://llvm.org/viewvc/llvm-project?rev=345593&view=rev
Log:
[X86] Re-enable the machine verifier after fixing more tests

Was disabled again in r345528. Hopefully this the bots.

Modified:
    llvm/trunk/lib/Target/X86/X86TargetMachine.h
    llvm/trunk/test/DebugInfo/Generic/linear-dbg-value.ll
    llvm/trunk/test/ThinLTO/X86/cfi-devirt.ll
    llvm/trunk/test/ThinLTO/X86/devirt-after-icp.ll

Modified: llvm/trunk/lib/Target/X86/X86TargetMachine.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetMachine.h?rev=345593&r1=345592&r2=345593&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86TargetMachine.h (original)
+++ llvm/trunk/lib/Target/X86/X86TargetMachine.h Tue Oct 30 05:20:17 2018
@@ -53,10 +53,6 @@ public:
   TargetLoweringObjectFile *getObjFileLowering() const override {
     return TLOF.get();
   }
-
-  bool isMachineVerifierClean() const override {
-    return false;
-  }
 };
 
 } // end namespace llvm

Modified: llvm/trunk/test/DebugInfo/Generic/linear-dbg-value.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Generic/linear-dbg-value.ll?rev=345593&r1=345592&r2=345593&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/Generic/linear-dbg-value.ll (original)
+++ llvm/trunk/test/DebugInfo/Generic/linear-dbg-value.ll Tue Oct 30 05:20:17 2018
@@ -1,4 +1,5 @@
-; RUN: llc -stop-before=expand-isel-pseudos -pre-RA-sched=linearize < %s | FileCheck %s
+; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39452.
+; RUN: llc -stop-before=expand-isel-pseudos -pre-RA-sched=linearize -verify-machineinstrs=0 < %s | FileCheck %s
 source_filename = "linear-dbg-value.ll"
 
 ; Function Attrs: nounwind readonly uwtable

Modified: llvm/trunk/test/ThinLTO/X86/cfi-devirt.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ThinLTO/X86/cfi-devirt.ll?rev=345593&r1=345592&r2=345593&view=diff
==============================================================================
--- llvm/trunk/test/ThinLTO/X86/cfi-devirt.ll (original)
+++ llvm/trunk/test/ThinLTO/X86/cfi-devirt.ll Tue Oct 30 05:20:17 2018
@@ -5,7 +5,9 @@
 ; RUN: opt -thinlto-bc -o %t.o %s
 
 ; Legacy PM
+; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39436.
 ; RUN: llvm-lto2 run %t.o -save-temps -pass-remarks=. \
+; RUN:   -verify-machineinstrs=0 \
 ; RUN:   -o %t3 \
 ; RUN:   -r=%t.o,test,px \
 ; RUN:   -r=%t.o,_ZN1A1nEi,p \
@@ -22,7 +24,9 @@
 ; RUN: llvm-dis %t3.1.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR
 
 ; New PM
+; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39436.
 ; RUN: llvm-lto2 run %t.o -save-temps -use-new-pm -pass-remarks=. \
+; RUN:   -verify-machineinstrs=0 \
 ; RUN:   -o %t3 \
 ; RUN:   -r=%t.o,test,px \
 ; RUN:   -r=%t.o,_ZN1A1nEi,p \

Modified: llvm/trunk/test/ThinLTO/X86/devirt-after-icp.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ThinLTO/X86/devirt-after-icp.ll?rev=345593&r1=345592&r2=345593&view=diff
==============================================================================
--- llvm/trunk/test/ThinLTO/X86/devirt-after-icp.ll (original)
+++ llvm/trunk/test/ThinLTO/X86/devirt-after-icp.ll Tue Oct 30 05:20:17 2018
@@ -45,7 +45,9 @@
 ; RUN: opt -thinlto-bc -o %t.o %s
 
 ; Legacy PM
+; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39436.
 ; RUN: llvm-lto2 run %t.o -save-temps -pass-remarks=. \
+; RUN:   -verify-machineinstrs=0 \
 ; RUN:   -o %t3 \
 ; RUN:   -r=%t.o,_Z3bazP1A,px \
 ; RUN:   -r=%t.o,_ZN1A3fooEv, \
@@ -63,7 +65,9 @@
 ; RUN: llvm-dis %t3.1.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR
 
 ; New PM
+; FIXME: Fix machine verifier issues and remove -verify-machineinstrs=0. PR39436.
 ; RUN: llvm-lto2 run %t.o -save-temps -use-new-pm -pass-remarks=. \
+; RUN:   -verify-machineinstrs=0 \
 ; RUN:   -o %t3 \
 ; RUN:   -r=%t.o,_Z3bazP1A,px \
 ; RUN:   -r=%t.o,_ZN1A3fooEv, \




More information about the llvm-commits mailing list