[PATCH] D53846: Check shouldReduceLoadWidth from SimplifySetCC
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 29 16:20:10 PDT 2018
rampitec marked 2 inline comments as done.
rampitec added inline comments.
================
Comment at: lib/Target/AMDGPU/AMDGPUISelLowering.cpp:676-677
+ AMDGPUInstrInfo::isUniformMMO(MN->getMemOperand()) &&
+ (AS == AMDGPUAS::CONSTANT_ADDRESS ||
+ AS == AMDGPUAS::CONSTANT_ADDRESS_32BIT))
+ return false;
----------------
arsenm wrote:
> arsenm wrote:
> > What about the load from uniform global that uses a scalar load?
> Also the address space check should go before the isUNiformMMO
Something else prevents it, but I have added a check for completeness.
https://reviews.llvm.org/D53846
More information about the llvm-commits
mailing list