[PATCH] D53507: [InstCombine] try to turn shuffle into insertelement

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: lib/Transforms/InstCombine/InstCombineVectorOps.cpp:1579
+    IndexC = ConstantInt::get(IndexC->getType(), NewInsIndex);
+    return true;
+  };
----------------
Worth returning an ConstantInt*/nullptr instead? Mainly to remove the external IndexC being used for the match at the start of the lambda.


https://reviews.llvm.org/D53507