[PATCH] D53803: [llvm-objdump] add support for '--syms' as an alias of -t (PR39406)

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 03:15:50 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D53803#1279991, @eush wrote:

> I would suggest renaming the test to `symbol-table-elf.test` for consistency with other `*-elf` tests in this directory.


I agree with this, but I think a separate change might be worthwhile to rename all of the *-elf tests to elf-*, as that better matches the majority of the coff-* and macho-* tests.

Otherwise, looks good, with the suggestions @eush has made.


https://reviews.llvm.org/D53803





More information about the llvm-commits mailing list