[PATCH] D53575: [X86][BMI1] X86DAGToDAGISel: select BEXTR from x & (-1 >> (32 - y)) pattern

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a couple of style minors



================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2754
+    if (ShiftAmt->getOpcode() == ISD::TRUNCATE) {
+      ShiftAmt = ShiftAmt->getOperand(0);
+      // The trunc should have been the only user of the real shift amount.
----------------
```
ShiftAmt.getOpcode()
ShiftAmt.getOperand(0)
```


================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2777
+      return false;
+    SDValue M1 = Mask->getOperand(1);
+    // The shift amount should not be used externally.
----------------
```
Mask.getOpcode()
Mask.getOperand(0)
Mask.getOperand(1)
```


Repository:
  rL LLVM

https://reviews.llvm.org/D53575