[PATCH] D53816: [TableGen:AsmWriter] Cope with consecutive tied operands.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 30 02:54:26 PDT 2018


rengolin added a comment.

Hi Simon,

This makes sense to me, and it's nice to see tablegen tests, but what is the real effect of this patch?

As you say in the description, it allows variants of the affected instructions (like UMLAL), but it does not specify which variants, nor it shows, via tests, how those would now be matched with the changes.

Can you add some tests for the affected instructions?

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D53816





More information about the llvm-commits mailing list