[PATCH] D53811: [MSan] another take at instrumenting inline assembly - now with calls

[Alexander Potapenko via Phabricator via llvm-commits]

glider added inline comments.


================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:3121
       if (Call->isInlineAsm()) {
-        if (ClHandleAsmConservative)
+        if (ClHandleAsmConservative && InsertChecks)
           visitAsmInstruction(I);
----------------
eugenis wrote:
> Why test for InsertCheck here?
> It is done in insertShadowCheck already, and unpoisoning of stores should be done even in blacklisted functions.
Fair enough, will remove.


https://reviews.llvm.org/D53811