[PATCH] D53440: [LoopUnroll] allow customization for new-pass-manager version of LoopUnroll

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added inline comments.


================
Comment at: include/llvm/Transforms/Scalar/LoopUnrollPass.h:51
+
+  /// Selector for the optional behavior - Partial unrolling.
+  /// When partial unrolling is disabled only full unrolling is left allowed.
----------------
fedor.sergeev wrote:
> chandlerc wrote:
> > I think more simple prose wolud be better here and below. For example:
> > 
> > "Enables or disables partial unrolling. When disabled, only full unrolling is allowed."
> > 
> > The "Selector for ... - ...." I think doesn't read easily.
> "Simple english prose" is not my strong point ;) Thanks for suggestion.
It's all good, I also struggle but in other directions of the same space. My English prose tends to ramble on and on (much like this comment), often saying far too little and completely failing to use commas correctly (also much like this comment). ;]

Honestly, *reviewing* for this is always much easier than writing it in the first place. So please don't ever feel bad for any comments in code review. I'm just really excited by all the work here.


Repository:
  rL LLVM

https://reviews.llvm.org/D53440