[PATCH] D45213: [COFF][LLD] Add link support for precompiled headers .objs

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.

In https://reviews.llvm.org/D45213#1275808, @aganea wrote:

> In https://reviews.llvm.org/D45213#1259147, @zturner wrote:
>
> > FWIW, all object files always start with an S_OBJNAME, even if there is no PCH support. But if there is no PCH support, the signature field will just be 0.
>
>
> Just wanted to point out that it's only true for `cl`-generated OBJs. `clang-cl` does not generate the `S_OBJNAME` record.


True. I added S_BUILDINFO the other week.

I think @zturner had a stalled patch to add S_OBJNAME. Yeah, this: https://reviews.llvm.org/D43002. I think the lesson is that it might be better not to stuff more things into DICompileUnit than absolutely necessary.

Is there anything else that needs to be done here? I'm happy with this.


https://reviews.llvm.org/D45213