[PATCH] D53229: [LegalizeTypes] Teach PromoteIntRes_BITCAST to better handle a bitcast with vector output type and a vector input type that needs to be widened

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 16:11:20 PDT 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:324
+                             DAG.getConstant(0, dl, IdxTy));
+          return DAG.getNode(ISD::ANY_EXTEND, dl, NOutVT, InOp);
+        }
----------------
craig.topper wrote:
> efriedma wrote:
> > Should we just generate an ANY_EXTEND_VECTOR_INREG directly here?
> I don't think I can. I don't have any guarantee of vectors of the same size here.
Oh, good point.  It looks like they are in the cases you've shown, but maybe not in general.


https://reviews.llvm.org/D53229





More information about the llvm-commits mailing list