[PATCH] D53842: [WebAssembly] Parsing missing directives to produce valid .o

[Derek Schuff via Phabricator via llvm-commits]

dschuff added inline comments.


================
Comment at: include/llvm/ADT/StringSwitch.h:214
+    return std::move(Result);
+  }
+
----------------
aardappel wrote:
> Since this is a core LLVM class, should I get someone in particular to review? Or am I better off writing the calling code differently?
For our use case, we have `T = wasm::WasmSymbolType` and `R` defaults to `T`. Could we set `R` to `Optional<wasm::WasmSymbolType>` and just use `Default` instead of `NoDefault`?


Repository:
  rL LLVM

https://reviews.llvm.org/D53842