[PATCH] D53733: [llvm-objcopy] Fix --keep-global-symbol/--globalize-symbol for undefined symbols.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 15:48:00 PDT 2018


rupprecht added a comment.

In https://reviews.llvm.org/D53733#1278600, @jhenderson wrote:

> My feeling is that a single separate test is not the right way to test this. I think it makes more sense for an undefined symbol to be added to globalize.test and --keep-global-symbols.test. What do you think?


Makes sense to me -- done.


Repository:
  rL LLVM

https://reviews.llvm.org/D53733





More information about the llvm-commits mailing list