[PATCH] D53545: [DWARF][NFC] NFC patch for reverted r342218 (refactoring rangelist handling)

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 15:46:10 PDT 2018


echristo added inline comments.


================
Comment at: llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFListTable.h:165
+  /// True if this list is located in a split-DWARF (dwo or dwp) file.
+  bool isDWO;
   /// This string is displayed as a heading before the list is dumped
----------------
dblaikie wrote:
> echristo wrote:
> > Trying to figure out a way around isDWO as a boolean argument and data member would be great.
> Avoiding it being a boolean, or avoiding having the same name for an argument and data member at the same time?
The former. I'd like to avoid the boolean existing if we can avoid it, and definitely as an argument to the constructor as well. 


Repository:
  rL LLVM

https://reviews.llvm.org/D53545





More information about the llvm-commits mailing list