[PATCH] D53786: [AliasSetTracker] Actually delete instructions from the AliasSetTracker.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In https://reviews.llvm.org/D53786#1279569, @reames wrote:

> This feels like possibly a solution in search of a problem?


One potentially problematic scenario in the current code would be if someone recursively deleted a user instruction inside an AST iteration loop.  I think that would delete the pointer value, and if that was the last value in a given AS, invalidate the iteration.

What I'm not entirely clear about is why we care about deleting empty AliasSets from the AST eagerly?  That's probably a deeper design question though.


Repository:
  rL LLVM

https://reviews.llvm.org/D53786