[PATCH] D53821: [ELF][PPC64]Workaround bogus Visual Studio build warning

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 10:06:57 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D53821#1279012, @sfertile wrote:

> Thanks for cleaning this up. LGTM.
>
> > We could also fix this by using INT32_MIN or std::numeric_limts<int32_t>::min(), if preferred
>
> Personally I prefer either of those over the raw numeric literal.


Thanks, I've updated it, and will land the patch tomorrow, as I'm just leaving the office now.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D53821





More information about the llvm-commits mailing list