[PATCH] D53729: [llvm-cov] Don't remap existing paths

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

In https://reviews.llvm.org/D53729#1278901, @greened wrote:

> > Maybe we could just add 'REQUIRES: build-dir-not-slash-tmp' or something to the affected lit tests.
>
> It would be unfortunate to disable tests just because of this issue.  I understand your point, though, and remapping always certainly has simpler semantics.
>
> How difficult is it to add new REQUIRES clauses?  I've never done it before.


It's not too bad, test/lit.cfg.py has several examples. You can add a 'feature' by doing `config.available_features.add("name-of-feature")`. Then you can add `REQUIRES: name-of-feature` to any test.

> Would it make sense to try to change the tests to not need remapping of /tmp?  I don't know how I'd do that, so ideas are welcome.

The only I way I see of doing that is to regenerate the .covmapping binary blobs so that they refer to a different path (instructions for doing this are in the tests). This doesn't eliminate the possibility of name conflicts in principle (although in practice it might).


Repository:
  rL LLVM

https://reviews.llvm.org/D53729