[PATCH] D53690: [llvm-objdump] Don't Crash When Using `-a` on Non-Archives (PR39402)

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 29 04:41:05 PDT 2018


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the nit.



================
Comment at: test/tools/llvm-objdump/non-archive-object.test:4
+
+# If this test not crashed, then this test passed.
+# CHECK: file format ELF64-x86-64
----------------
Nit: "If this test **has** not crashed..."


https://reviews.llvm.org/D53690





More information about the llvm-commits mailing list