[PATCH] D52694: [bindings/go] Add EraseFromParent

[whitequark via Phabricator via llvm-commits]

whitequark accepted this revision.
whitequark added inline comments.
This revision is now accepted and ready to land.


================
Comment at: bindings/go/llvm/ir.go:1213
 // Operations on instructions
+func (v Value) EraseFromParentAsInstruction()      { C.LLVMInstructionEraseFromParent(v.C) }
 func (v Value) InstructionParent() (bb BasicBlock) { bb.C = C.LLVMGetInstructionParent(v.C); return }
----------------
aykevl wrote:
> aykevl wrote:
> > whitequark wrote:
> > > Nit: I'd call this `EraseInstructionFromParent`. (Also I'd deprecate `EraseFromParent` and rename it to `EraseBasicBlockFromParent`, but I'm not the Go bindings code owner so it's not my call.)
> > Yes, that sounds better but I've kept it consistent with EraseFromParentAsFunction and EraseFromParentAsGlobal. Should it be changed, then?
> ping?
I'm not the Go bindings code owner so it seems better to go with the conservative naming.


Repository:
  rL LLVM

https://reviews.llvm.org/D52694