[PATCH] D53626: [LLVM-C] Improve Intrinsics Bindings

[whitequark via Phabricator via llvm-commits]

whitequark requested changes to this revision.
whitequark added a comment.
This revision now requires changes to proceed.

LGTM other than the argument types.



================
Comment at: include/llvm-c/Core.h:2393
+                                         LLVMTypeRef *ParamTypes,
+                                         unsigned ParamCount);
+
----------------
`size_t ParamCount`, following other declarations.


================
Comment at: include/llvm-c/Core.h:2402
+LLVMTypeRef LLVMIntrinsicGetType(LLVMContextRef Ctx, unsigned ID,
+                                 LLVMTypeRef *ParamTypes, unsigned ParamCount);
+
----------------
`size_t ParamCount`, following other declarations.


================
Comment at: include/llvm-c/Core.h:2422
+                                            LLVMTypeRef *ParamTypes,
+                                            unsigned ParamCount,
+                                            size_t *NameLength);
----------------
`size_t ParamCount`, following other declarations.


Repository:
  rL LLVM

https://reviews.llvm.org/D53626