[PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

[Alexander Polyakov via Phabricator via llvm-commits]

apolyakov added a comment.

Here it is:

  build/bin/llvm-lit -avv llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test -- Testing: 1 tests, 1 threads --
  FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of 1)
  ******************** TEST 'lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test' FAILED ********************
  Script:
  --
  : 'RUN: at line 4';   /home/alexander/workspace/gsoc/build/./bin/clang -o /home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c -g
  : 'RUN: at line 5';   /home/alexander/workspace/gsoc/build/bin/lldb-mi --synchronous /home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp < /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test | /home/alexander/workspace/gsoc/build/bin/FileCheck /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test --dump-input-on-failure
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:22:10: error: CHECK: expected string not found in input
  # CHECK: =breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="{{0x[0-9a-f]*[^f][0-9a-f]*}}",func="??",file="??",fullname="??/??",line="0",pending=["printf"],times="{{0|1}}",original-location="printf"}
           ^
  <stdin>:39:1: note: scanning from here
  =thread-group-started,id="i1",pid="5022"
  ^
  Full input was:
  <<<<<<
  (gdb)
  -file-exec-and-symbols "/home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp"
  ^done
  (gdb)
  ^done
  (gdb)
  =library-loaded,id="/home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp",target-name="/home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp",host-name="/home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp",symbols-loaded="0",loaded_addr="-",size="0"
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^error,msg="Command 'break-insert'. Breakpoint location 'printf' not found"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done,value="on"
  (gdb)
  ^done
  (gdb)
  ^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="??",file="??",fullname="??/??",line="0",pending=["printf"],times="0",original-location="printf"}
  (gdb)
  =breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0xffffffffffffffff",func="??",file="??",fullname="??/??",line="0",pending=["printf"],times="0",original-location="printf"}
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^running
  =thread-group-started,id="i1",pid="5022"
  (gdb)
  =thread-created,id="1",group-id="i1"
  =thread-selected,id="1"
  (gdb)
  =library-loaded,id="/lib/x86_64-linux-gnu/ld-2.23.so",target-name="/lib/x86_64-linux-gnu/ld-2.23.so",host-name="/lib/x86_64-linux-gnu/ld-2.23.so",symbols-loaded="1",symbols-path="/usr/lib/debug/lib/x86_64-linux-gnu/ld-2.23.so",loaded_addr="-",size="0"
  (gdb)
  =library-loaded,id="[vdso]",target-name="[vdso]",host-name="[vdso]",symbols-loaded="1",symbols-path="",loaded_addr="0x00007ffff7ffa000",size="0"
  (gdb)
  =library-loaded,id="/home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp",target-name="/home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp",host-name="/home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp",symbols-loaded="0",loaded_addr="-",size="0"
  1 location added to breakpoint 2
  (gdb)
  =library-loaded,id="/lib/x86_64-linux-gnu/libc.so.6",target-name="/lib/x86_64-linux-gnu/libc.so.6",host-name="/lib/x86_64-linux-gnu/libc.so.6",symbols-loaded="1",symbols-path="/usr/lib/debug/lib/x86_64-linux-gnu/libc-2.23.so",loaded_addr="-",size="0"
  =breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="0x00007ffff7a6285b",func="__printf",file="printf.c",fullname="/build/glibc-bfm8X4/glibc-2.23/stdio-common/printf.c",line="32",pending=["printf"],times="1",original-location="printf"}
  (gdb)
  (gdb)
  =library-loaded,id="/lib/x86_64-linux-gnu/libc.so.6",target-name="/lib/x86_64-linux-gnu/libc.so.6",host-name="/lib/x86_64-linux-gnu/libc.so.6",symbols-loaded="1",symbols-path="/usr/lib/debug/lib/x86_64-linux-gnu/libc-2.23.so",loaded_addr="-",size="0"
  (gdb)
  *stopped,reason="breakpoint-hit",disp="del",bkptno="2",frame={level="0",addr="0x00007ffff7a6285b",func="__printf",args=[{name="format",value="0x00000000004005d4 \"Print a formatted string so that GCC does not optimize this printf call: %s\\\\n\""}],file="printf.c",fullname="/build/glibc-bfm8X4/glibc-2.23/stdio-common/printf.c",line="32"},thread-id="1",stopped-threads="all"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  =breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="n",addr="0x00007ffff7a6285b",func="__printf",file="printf.c",fullname="/build/glibc-bfm8X4/glibc-2.23/stdio-common/printf.c",line="32",pending=["printf"],times="1",original-location="printf"}
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^running
  (gdb)
  @"Print a formatted string so that GCC does not optimize this printf call: /home/alexander/workspace/gsoc/build/tools/lldb/lit/tools/lldb-mi/breakpoint/Output/break-insert-enable-pending.test.tmp\r\n"
  (gdb)
  =thread-exited,id="1",group-id="i1"
  =thread-group-exited,id="i1",exit-code="0"
  *stopped,reason="exited-normally"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done,value="on"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done,value="off"
  (gdb)
  ^done
  (gdb)
  ^error,msg="Command 'break-insert'. Breakpoint location 'printf-non-existent' not found"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done,value="on"
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done
  (gdb)
  ^done,value="off"
  (gdb)
  ^done
  (gdb)
  ^error,msg="'breakpoint' expects "pending on" or "pending off""
  (gdb)
  ^done
  (gdb)
  
  >>>>>>
  
  --
  
  ********************
  Testing Time: 0.70s
  ********************
  Failing Tests (1):
      lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test
  
    Unexpected Failures: 1


https://reviews.llvm.org/D52953