[PATCH] D53379: GSYM symbolication format

[Greg Clayton via Phabricator via llvm-commits]

clayborg added inline comments.


================
Comment at: include/llvm/DebugInfo/GSYM/GsymReader.h:119
+  std::unique_ptr<MemoryBuffer> MemBuffer;
+  mutable BinaryStreamReader GSYMData;
+  const Header *GSYMHeader = nullptr;
----------------
zturner wrote:
> Why does this need to be mutable?
because BinaryStreamReader must use BinaryStreamReader::setOffset() before reading data because it contains the file position. Many functions should be const, but they can't be if they access any data in GSYMData.


https://reviews.llvm.org/D53379