[llvm] r345169 - [Hexagon] Flip hexagon-autohvx to be true by default

Alina Sbirlea via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 21:58:06 PDT 2018


Hi Krzysztof,

Reverted in r345446 <https://reviews.llvm.org/rL345446> and r345447
<https://reviews.llvm.org/rL345447>.

Thank you,
Alina


On Fri, Oct 26, 2018 at 5:35 PM Krzysztof Parzyszek <kparzysz at codeaurora.org>
wrote:

> Hi Alina,
> Feel free to revert, but please revert both patches.
> I can do it, but it'll have to wait until Monday.
>
> -Krzysztof
>
> On 10/26/2018 6:03 PM, Alina Sbirlea wrote:
> > FYI, this breaks some of our Halide tests. We're seeing timeouts (tests
> > hanging or taking a very large amount of time to compile).
> > We're looking to obtain a reproducer, but reverting would be good in
> > order to unblock folks.
> >
> > On Wed, Oct 24, 2018 at 10:57 AM Krzysztof Parzyszek via llvm-commits
> > <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>>
> wrote:
> >
> >     Author: kparzysz
> >     Date: Wed Oct 24 10:55:13 2018
> >     New Revision: 345169
> >
> >     URL: http://llvm.org/viewvc/llvm-project?rev=345169&view=rev
> >     Log:
> >     [Hexagon] Flip hexagon-autohvx to be true by default
> >
> >     This will allow other generators of LLVM IR to use the
> auto-vectorizer
> >     without having to change that flag.
> >
> >     Note: on its own, this patch will enable auto-vectorization on
> Hexagon
> >     in all cases, regardless of the -fvectorize flag. There is a
> companion
> >     clang patch that together with this one forms an NFC for clang users.
> >
> >     Modified:
> >          llvm/trunk/lib/Target/Hexagon/HexagonTargetTransformInfo.cpp
> >
> >     Modified:
> llvm/trunk/lib/Target/Hexagon/HexagonTargetTransformInfo.cpp
> >     URL:
> >
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonTargetTransformInfo.cpp?rev=345169&r1=345168&r2=345169&view=diff
> >
>  ==============================================================================
> >     --- llvm/trunk/lib/Target/Hexagon/HexagonTargetTransformInfo.cpp
> >     (original)
> >     +++ llvm/trunk/lib/Target/Hexagon/HexagonTargetTransformInfo.cpp Wed
> >     Oct 24 10:55:13 2018
> >     @@ -28,7 +28,7 @@ using namespace llvm;
> >
> >       #define DEBUG_TYPE "hexagontti"
> >
> >     -static cl::opt<bool> HexagonAutoHVX("hexagon-autohvx",
> cl::init(false),
> >     +static cl::opt<bool> HexagonAutoHVX("hexagon-autohvx",
> cl::init(true),
> >         cl::Hidden, cl::desc("Enable loop vectorizer for HVX"));
> >
> >       static cl::opt<bool> EmitLookupTables("hexagon-emit-lookup-tables",
> >
> >
> >     _______________________________________________
> >     llvm-commits mailing list
> >     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> >     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> >
> >
> > <
> http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient>
>
> >       Virus-free. www.avg.com
> > <
> http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient>
>
> >
> >
> > <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181026/4345a38d/attachment.html>


More information about the llvm-commits mailing list