[PATCH] D50166: [ARM64] [Windows] MCLayer support for exception handling
Sanjin Sijaric via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 26 16:07:17 PDT 2018
ssijaric added a comment.
In https://reviews.llvm.org/D50166#1277766, @rnk wrote:
> In https://reviews.llvm.org/D50166#1276921, @ssijaric wrote:
>
> > So, I will skip a test case for shrink wrapping. Will add a few more tests to cover remaining the unwind codes.
>
>
> Can you copy a test where shrink wrapping would fire, and validate that it does not for aarch64-windows-gnu? Without the test, someone could remove the logic you found and no tests would fail. We have a test like this for x86_64.
Sure, I will add a test case that gets shrink wrapped on aarch64-linux, but doesn't get shrink wrapped on aarch64-windows.
Repository:
rL LLVM
https://reviews.llvm.org/D50166
More information about the llvm-commits
mailing list