[PATCH] D53158: [buildbot, windows] Update the way the visual studio environment is set

[Stella Stamenova via Phabricator via llvm-commits]

stella.stamenova added a comment.

In https://reviews.llvm.org/D53158#1277851, @gkistanova wrote:

> Hi Stella,
>
> Please see my notes inline.
>
> Unless you want to do this by yourself, I can prepare this change. I think I have developed a good understanding of what you are after.


Thanks, Galina. If you think it will be easier for you to make the change, that sounds great.



================
Comment at: zorg/buildbot/builders/Util.py:26
+        cmd = [VSWHERE_PATH, "-latest", "-property", "installationPath"]
+        vs_path = subprocess.check_output(cmd).strip()
+        vcvars_command = pjoin(vs_path, 'VC', 'Auxiliary', 'Build', 'vcvarsall.bat')
----------------
gkistanova wrote:
> This thing also would run on the build master, which does not look like what you want.
Yes, that's where vswhere is called and it has to run on the machine that will run the build.


Repository:
  rL LLVM

https://reviews.llvm.org/D53158