[PATCH] D52100: [tblgen] Allow FixedLenDecoderEmitter to use APInt-like objects as InsnType

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a comment.

In https://reviews.llvm.org/D52100#1277769, @Sonicadvance1 wrote:

> This commit breaks my 128bit instruction target.
>  I'm currently using a workaround locally for enabling APInt based encodings when your instruction encoding is >64bit.
>  The main issue with this approach is that getBinaryCodeForInstr completely falls apart.


Could you elaborate on this? getBinaryCodeForInstr() is for encoding instructions whereas FixedLenDecoderEmitter generates a decoder so I'm surprised that you're seeing a connection between getBinaryCodeForInstr() and this patch. Our out-of-tree target didn't use the FixedLenDecoderEmitter until after this patch made it possible but we've been using getBinaryCodeForInstr() for a very long time so I think there's unlikely to be a connection between the two. Additionally, not affecting encoding was a requirement for us as we're also working around the lack of >64-bit support in getBinaryCodeForInstr()


Repository:
  rL LLVM

https://reviews.llvm.org/D52100