[PATCH] D53379: GSYM symbolication format

[Greg Clayton via Phabricator via llvm-commits]

clayborg updated this revision to Diff 171351.
clayborg added a comment.

Most of Zachary's fixes are in this path. Few major differences:

- Updated the README.md
  - be more specific about the string table encoding
  - specify address info offsets are offsets relative to the start of the GSYM header
- Update GsymReader
  - Switched over to using BinaryStreamReader and removed DataRef class
  - Use llvm::ArrayRef instead of pointers for AddrOffsets, AddrInfoOffsets, and Files (file table)
- Switch to DenseMap and StringMap where applicable
- Removed use of std::shared_ptr for string tables and file tables
- Made GsymCreator thread safe and cleaned up multi-threaded code
- Removed segmenting code until we get all classes in the right shape. Will commit this back after first checkin once format is locked down
- Added unit tests


https://reviews.llvm.org/D53379

Files:
  include/llvm/DebugInfo/GSYM/Breakpad.h
  include/llvm/DebugInfo/GSYM/DwarfTransformer.h
  include/llvm/DebugInfo/GSYM/FileEntry.h
  include/llvm/DebugInfo/GSYM/FileTableCreator.h
  include/llvm/DebugInfo/GSYM/FileWriter.h
  include/llvm/DebugInfo/GSYM/FunctionInfo.h
  include/llvm/DebugInfo/GSYM/GsymCreator.h
  include/llvm/DebugInfo/GSYM/GsymReader.h
  include/llvm/DebugInfo/GSYM/GsymStreamer.h
  include/llvm/DebugInfo/GSYM/InlineInfo.h
  include/llvm/DebugInfo/GSYM/LineEntry.h
  include/llvm/DebugInfo/GSYM/LineTable.h
  include/llvm/DebugInfo/GSYM/LookupResult.h
  include/llvm/DebugInfo/GSYM/Range.h
  include/llvm/DebugInfo/GSYM/StringTable.h
  include/llvm/DebugInfo/GSYM/StringTableCreator.h
  include/llvm/Support/DataExtractor.h
  lib/DebugInfo/CMakeLists.txt
  lib/DebugInfo/GSYM/Breakpad.cpp
  lib/DebugInfo/GSYM/CMakeLists.txt
  lib/DebugInfo/GSYM/DwarfTransformer.cpp
  lib/DebugInfo/GSYM/FileTableCreator.cpp
  lib/DebugInfo/GSYM/FileWriter.cpp
  lib/DebugInfo/GSYM/FunctionInfo.cpp
  lib/DebugInfo/GSYM/GsymCreator.cpp
  lib/DebugInfo/GSYM/GsymReader.cpp
  lib/DebugInfo/GSYM/GsymStreamer.cpp
  lib/DebugInfo/GSYM/InlineInfo.cpp
  lib/DebugInfo/GSYM/LineTable.cpp
  lib/DebugInfo/GSYM/LookupResult.cpp
  lib/DebugInfo/GSYM/README.md
  lib/DebugInfo/GSYM/Range.cpp
  tools/gsym/CMakeLists.txt
  tools/gsym/llvm-gsymutil.cpp
  unittests/DebugInfo/CMakeLists.txt
  unittests/DebugInfo/GSYM/CMakeLists.txt
  unittests/DebugInfo/GSYM/GSYMTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53379.171351.patch
Type: text/x-patch
Size: 155355 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181026/73f271ac/attachment.bin>