[PATCH] D51664: [IR] Lazily number instructions for local dominance queries

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 14:08:29 PDT 2018


nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/BasicBlock.h:490
+/// implemented in the .cpp file to avoid circular header deps.
+inline void Instruction::validateInstrOrdering() const {}
+#endif
----------------
This should probably be `BasicBlock::validateInstrOrdering()` rather than `Instruction::validateInstrOrdering()`.


https://reviews.llvm.org/D51664





More information about the llvm-commits mailing list