[PATCH] D53673: [COFF, ARM64] Implement Intrinsic.sponentry for AArch64

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 13:04:09 PDT 2018


mstorsjo added inline comments.


================
Comment at: test/CodeGen/AArch64/sponentry.ll:22
+
+define dso_local void @foo([24 x i64]*) {
+  %2 = alloca [24 x i64]*, align 8
----------------
mstorsjo wrote:
> Are you sure this actually triggers the fixed object codepath? (This looks a lot like the test example I posted earlier, and that wasn't at least designed to trigger fixed objects.) I think at least a function with varargs has fixed objects.
Indeed, I tested this, and both functions show `numFixed = 0`. So is the other codepath actually tested with some other code, or still untested?


Repository:
  rL LLVM

https://reviews.llvm.org/D53673





More information about the llvm-commits mailing list