[PATCH] D50166: [ARM64] [Windows] MCLayer support for exception handling
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 26 11:38:44 PDT 2018
efriedma added a comment.
> A follow on patch will take care of scheduling
That seems fine. The fix is likely orthogonal to the other changes. (Maybe you need to override isSchedulingBoundary?)
> Also, need a patch to fix the formatting in llvm-readobj (e.g. the indentation in wineh2.mir is off for floating point saves/restores).
FileCheck collapses whitespace; you can fix that in your MIR testcases independently of the readobj fix.
================
Comment at: lib/MC/MCWin64EH.cpp:505
+
+ // Extended Code Words, Extended Epilog Count
+ uint32_t row2 = 0x0;
----------------
The extended code word handling is still wrong.
Repository:
rL LLVM
https://reviews.llvm.org/D50166
More information about the llvm-commits
mailing list