[PATCH] D53332: Access ADDLIB in llvm-ar via command line

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 11:05:44 PDT 2018


jyknight added inline comments.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:99
   [l] - ignored for compatibility
+  [L] - add archive's contents
   [o] - preserve original dates
----------------
Maybe say "For ar archives in [files], add each member, rather than the archive itself." or something along those lines, to indicate that both .a and .o files are handled with L.


================
Comment at: tools/llvm-ar/llvm-ar.cpp:344
+  if (AddLibrary && Operation != QuickAppend)
+    fail("The 'L' modifier is only applicable to the 'q' operation");
 
----------------
Seems a bit odd that it doesn't work with 'r'?


Repository:
  rL LLVM

https://reviews.llvm.org/D53332





More information about the llvm-commits mailing list