[llvm] r345384 - [CodeGen] Remove out operands from PATCHABLE_OP

Francis Visoiu Mistrih via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 06:37:26 PDT 2018


Author: thegameg
Date: Fri Oct 26 06:37:25 2018
New Revision: 345384

URL: http://llvm.org/viewvc/llvm-project?rev=345384&view=rev
Log:
[CodeGen] Remove out operands from PATCHABLE_OP

The current model requires 1 out operand, but it is not used nor created.

This fixed an x86 machine verifier issue.

Part of PR27481.

Modified:
    llvm/trunk/include/llvm/Target/Target.td
    llvm/trunk/test/CodeGen/X86/patchable-prologue.ll

Modified: llvm/trunk/include/llvm/Target/Target.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/Target.td?rev=345384&r1=345383&r2=345384&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Target/Target.td (original)
+++ llvm/trunk/include/llvm/Target/Target.td Fri Oct 26 06:37:25 2018
@@ -1104,7 +1104,7 @@ def FAULTING_OP : StandardPseudoInstruct
   let isBranch = 1;
 }
 def PATCHABLE_OP : StandardPseudoInstruction {
-  let OutOperandList = (outs unknown:$dst);
+  let OutOperandList = (outs);
   let InOperandList = (ins variable_ops);
   let usesCustomInserter = 1;
   let mayLoad = 1;

Modified: llvm/trunk/test/CodeGen/X86/patchable-prologue.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/patchable-prologue.ll?rev=345384&r1=345383&r2=345384&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/patchable-prologue.ll (original)
+++ llvm/trunk/test/CodeGen/X86/patchable-prologue.ll Fri Oct 26 06:37:25 2018
@@ -1,5 +1,5 @@
-; RUN: llc -filetype=obj -o - -mtriple=x86_64-apple-macosx < %s | llvm-objdump -triple x86_64-apple-macosx -disassemble - | FileCheck %s
-; RUN: llc -mtriple=x86_64-apple-macosx < %s | FileCheck %s --check-prefix=CHECK-ALIGN
+; RUN: llc -verify-machineinstrs -filetype=obj -o - -mtriple=x86_64-apple-macosx < %s | llvm-objdump -triple x86_64-apple-macosx -disassemble - | FileCheck %s
+; RUN: llc -verify-machineinstrs -mtriple=x86_64-apple-macosx < %s | FileCheck %s --check-prefix=CHECK-ALIGN
 
 declare void @callee(i64*)
 




More information about the llvm-commits mailing list