[PATCH] D53659: [ValueTracking] peek through shuffles in ComputeNumSignBits (PR37549)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 05:33:07 PDT 2018


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: lib/Analysis/ValueTracking.cpp:2520
+      break;
+
+    // Look through shuffle of 1 source vector.
----------------
assert that both ops aren't undef?


https://reviews.llvm.org/D53659





More information about the llvm-commits mailing list