[PATCH] D53730: [llvm-readobj] Fix bugs with unrecognized types in switch statements

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 26 02:23:59 PDT 2018


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

I think it is possible just to add a precompiled binary(ies) to tools\llvm-readobj\Inputs and write the corresponding test(s).
But honestly I am not in favor of using precompiled binaries and in this case, perhaps it is fine to skip the test,
the issue seems to be obvious, so LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D53730





More information about the llvm-commits mailing list