[llvm] r345366 - [PowerPC] Fix some missed optimization opportunities in combineSetCC
Li Jia He via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 25 23:48:54 PDT 2018
Author: helijia
Date: Thu Oct 25 23:48:53 2018
New Revision: 345366
URL: http://llvm.org/viewvc/llvm-project?rev=345366&view=rev
Log:
[PowerPC] Fix some missed optimization opportunities in combineSetCC
For both operands are bool, short, int, long, long long, add the following optimization.
1. 0-x == y --> x+y ==0
2. 0-x != y --> x+y != 0
Review: nemanjai
Differential Revision: https://reviews.llvm.org/D53360
Modified:
llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h
llvm/trunk/test/CodeGen/PowerPC/combine-setcc.ll
Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp?rev=345366&r1=345365&r2=345366&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.cpp Thu Oct 25 23:48:53 2018
@@ -11823,6 +11823,37 @@ SDValue PPCTargetLowering::DAGCombineExt
ShiftCst);
}
+SDValue PPCTargetLowering::combineSetCC(SDNode *N,
+ DAGCombinerInfo &DCI) const {
+ assert(N->getOpcode() == ISD::SETCC &&
+ "Should be called with a SETCC node");
+
+ ISD::CondCode CC = cast<CondCodeSDNode>(N->getOperand(2))->get();
+ if (CC == ISD::SETNE || CC == ISD::SETEQ) {
+ SDValue LHS = N->getOperand(0);
+ SDValue RHS = N->getOperand(1);
+
+ // If there is a '0 - y' pattern, canonicalize the pattern to the RHS.
+ if (LHS.getOpcode() == ISD::SUB && isNullConstant(LHS.getOperand(0)) &&
+ LHS.hasOneUse())
+ std::swap(LHS, RHS);
+
+ // x == 0-y --> x+y == 0
+ // x != 0-y --> x+y != 0
+ if (RHS.getOpcode() == ISD::SUB && isNullConstant(RHS.getOperand(0)) &&
+ RHS.hasOneUse()) {
+ SDLoc DL(N);
+ SelectionDAG &DAG = DCI.DAG;
+ EVT VT = N->getValueType(0);
+ EVT OpVT = LHS.getValueType();
+ SDValue Add = DAG.getNode(ISD::ADD, DL, OpVT, LHS, RHS.getOperand(1));
+ return DAG.getSetCC(DL, VT, Add, DAG.getConstant(0, DL, OpVT), CC);
+ }
+ }
+
+ return DAGCombineTruncBoolExt(N, DCI);
+}
+
// Is this an extending load from an f32 to an f64?
static bool isFPExtLoad(SDValue Op) {
if (LoadSDNode *LD = dyn_cast<LoadSDNode>(Op.getNode()))
@@ -12554,6 +12585,9 @@ SDValue PPCTargetLowering::PerformDAGCom
case ISD::TRUNCATE:
return combineTRUNCATE(N, DCI);
case ISD::SETCC:
+ if (SDValue CSCC = combineSetCC(N, DCI))
+ return CSCC;
+ LLVM_FALLTHROUGH;
case ISD::SELECT_CC:
return DAGCombineTruncBoolExt(N, DCI);
case ISD::SINT_TO_FP:
Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h?rev=345366&r1=345365&r2=345366&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h Thu Oct 25 23:48:53 2018
@@ -1097,6 +1097,7 @@ namespace llvm {
SDValue combineSRL(SDNode *N, DAGCombinerInfo &DCI) const;
SDValue combineADD(SDNode *N, DAGCombinerInfo &DCI) const;
SDValue combineTRUNCATE(SDNode *N, DAGCombinerInfo &DCI) const;
+ SDValue combineSetCC(SDNode *N, DAGCombinerInfo &DCI) const;
/// ConvertSETCCToSubtract - looks at SETCC that compares ints. It replaces
/// SETCC with integer subtraction when (1) there is a legal way of doing it
Modified: llvm/trunk/test/CodeGen/PowerPC/combine-setcc.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/combine-setcc.ll?rev=345366&r1=345365&r2=345366&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/combine-setcc.ll (original)
+++ llvm/trunk/test/CodeGen/PowerPC/combine-setcc.ll Thu Oct 25 23:48:53 2018
@@ -7,8 +7,7 @@
define zeroext i1 @eq1(i1 zeroext %x, i1 zeroext %y) {
; CHECK-LABEL: eq1:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -21,8 +20,7 @@ define zeroext i1 @eq1(i1 zeroext %x, i1
define zeroext i8 @eq2(i8 zeroext %x, i8 zeroext %y) {
; CHECK-LABEL: eq2:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -37,8 +35,7 @@ define zeroext i8 @eq2(i8 zeroext %x, i8
define signext i16 @eq3(i16 signext %x, i16 signext %y) {
; CHECK-LABEL: eq3:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -53,8 +50,7 @@ define signext i16 @eq3(i16 signext %x,
define zeroext i16 @eq4(i16 zeroext %x, i16 zeroext %y) {
; CHECK-LABEL: eq4:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -69,8 +65,7 @@ define zeroext i16 @eq4(i16 zeroext %x,
define signext i32 @eq5(i32 signext %x, i32 signext %y) {
; CHECK-LABEL: eq5:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -83,8 +78,7 @@ define signext i32 @eq5(i32 signext %x,
define zeroext i32 @eq6(i32 zeroext %x, i32 zeroext %y) {
; CHECK-LABEL: eq6:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -97,8 +91,7 @@ define zeroext i32 @eq6(i32 zeroext %x,
define i64 @eq7(i64 %x, i64 %y) {
; CHECK-LABEL: eq7:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzd r3, r3
; CHECK-NEXT: rldicl r3, r3, 58, 63
; CHECK-NEXT: blr
@@ -111,8 +104,7 @@ define i64 @eq7(i64 %x, i64 %y) {
define zeroext i1 @eq8(i1 zeroext %x, i1 zeroext %y) {
; CHECK-LABEL: eq8:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -125,8 +117,7 @@ define zeroext i1 @eq8(i1 zeroext %x, i1
define zeroext i8 @eq9(i8 zeroext %x, i8 zeroext %y) {
; CHECK-LABEL: eq9:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r4, r4
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r3, r4
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -141,8 +132,7 @@ define zeroext i8 @eq9(i8 zeroext %x, i8
define signext i16 @eq10(i16 signext %x, i16 signext %y) {
; CHECK-LABEL: eq10:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r4, r4
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r3, r4
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -157,8 +147,7 @@ define signext i16 @eq10(i16 signext %x,
define zeroext i16 @eq11(i16 zeroext %x, i16 zeroext %y) {
; CHECK-LABEL: eq11:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r4, r4
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r3, r4
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -173,8 +162,7 @@ define zeroext i16 @eq11(i16 zeroext %x,
define signext i32 @eq12(i32 signext %x, i32 signext %y) {
; CHECK-LABEL: eq12:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r4, r4
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r3, r4
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -187,8 +175,7 @@ define signext i32 @eq12(i32 signext %x,
define zeroext i32 @eq13(i32 zeroext %x, i32 zeroext %y) {
; CHECK-LABEL: eq13:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r4, r4
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r3, r4
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: blr
@@ -201,8 +188,7 @@ define zeroext i32 @eq13(i32 zeroext %x,
define i64 @eq14(i64 %x, i64 %y) {
; CHECK-LABEL: eq14:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r4, r4
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r3, r4
; CHECK-NEXT: cntlzd r3, r3
; CHECK-NEXT: rldicl r3, r3, 58, 63
; CHECK-NEXT: blr
@@ -215,8 +201,7 @@ define i64 @eq14(i64 %x, i64 %y) {
define zeroext i1 @neq1(i1 zeroext %x, i1 zeroext %y) {
; CHECK-LABEL: neq1:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -230,8 +215,7 @@ define zeroext i1 @neq1(i1 zeroext %x, i
define zeroext i8 @neq2(i8 zeroext %x, i8 zeroext %y) {
; CHECK-LABEL: neq2:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -247,8 +231,7 @@ define zeroext i8 @neq2(i8 zeroext %x, i
define signext i16 @neq3(i16 signext %x, i16 signext %y) {
; CHECK-LABEL: neq3:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -264,8 +247,7 @@ define signext i16 @neq3(i16 signext %x,
define zeroext i16 @neq4(i16 zeroext %x, i16 zeroext %y) {
; CHECK-LABEL: neq4:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -281,8 +263,7 @@ define zeroext i16 @neq4(i16 zeroext %x,
define signext i32 @neq5(i32 signext %x, i32 signext %y) {
; CHECK-LABEL: neq5:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -296,8 +277,7 @@ define signext i32 @neq5(i32 signext %x,
define zeroext i32 @neq6(i32 zeroext %x, i32 zeroext %y) {
; CHECK-LABEL: neq6:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -311,8 +291,7 @@ define zeroext i32 @neq6(i32 zeroext %x,
define i64 @neq7(i64 %x, i64 %y) {
; CHECK-LABEL: neq7:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: addic r4, r3, -1
; CHECK-NEXT: subfe r3, r4, r3
; CHECK-NEXT: blr
@@ -325,8 +304,7 @@ define i64 @neq7(i64 %x, i64 %y) {
define zeroext i1 @neq8(i1 zeroext %x, i1 zeroext %y) {
; CHECK-LABEL: neq8:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -340,8 +318,7 @@ define zeroext i1 @neq8(i1 zeroext %x, i
define zeroext i8 @neq9(i8 zeroext %x, i8 zeroext %y) {
; CHECK-LABEL: neq9:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -357,8 +334,7 @@ define zeroext i8 @neq9(i8 zeroext %x, i
define signext i16 @neq10(i16 signext %x, i16 signext %y) {
; CHECK-LABEL: neq10:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -374,8 +350,7 @@ define signext i16 @neq10(i16 signext %x
define zeroext i16 @neq11(i16 zeroext %x, i16 zeroext %y) {
; CHECK-LABEL: neq11:
; CHECK: # %bb.0: # %entry
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -392,8 +367,7 @@ entry:
define signext i32 @neq12(i32 signext %x, i32 signext %y) {
; CHECK-LABEL: neq12:
; CHECK: # %bb.0: # %entry
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -408,8 +382,7 @@ entry:
define zeroext i32 @neq13(i32 zeroext %x, i32 zeroext %y) {
; CHECK-LABEL: neq13:
; CHECK: # %bb.0: # %entry
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r3, r4
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: cntlzw r3, r3
; CHECK-NEXT: srwi r3, r3, 5
; CHECK-NEXT: xori r3, r3, 1
@@ -424,8 +397,7 @@ entry:
define i64 @neq14(i64 %x, i64 %y) {
; CHECK-LABEL: neq14:
; CHECK: # %bb.0:
-; CHECK-NEXT: neg r3, r3
-; CHECK-NEXT: xor r3, r4, r3
+; CHECK-NEXT: add r3, r4, r3
; CHECK-NEXT: addic r4, r3, -1
; CHECK-NEXT: subfe r3, r4, r3
; CHECK-NEXT: blr
More information about the llvm-commits
mailing list