[PATCH] D50166: [ARM64] [Windows] MCLayer support for exception handling

[Sanjin Sijaric via Phabricator via llvm-commits]

ssijaric added a comment.

In https://reviews.llvm.org/D50166#1274871, @rnk wrote:

> In https://reviews.llvm.org/D50166#1273097, @efriedma wrote:
>
> > Missing test coverage for SEH_SaveFPLR_X, SEH_SaveReg, SEH_SaveFReg, SEH_SetFP, SEH_AddFP, SEH_Nop, and the alloc_s variant of SEH_StackAlloc.  (I'd like to see at least one use of each opcode to show the encoding is correct/consistent with llvm-readobj.)
>
>
> I'd also like to see a test for shrink-wrapping. You may have to disable it if you cannot yet describe such prologues it with SEH_ opcodes.


Hi Reid,

I think shrink wrapping is disabled by default for AArch64.  I have a small test case that gets shrink-wrapped, but only if I enable it manually using -enable-shrink-wrap.  Do we need a test case if it's disabled by default?


Repository:
  rL LLVM

https://reviews.llvm.org/D50166