[PATCH] D53739: InstCombine: Avoid introducing posion values when lowering llvm.amdgcn.[us]bfe

Bas Nieuwenhuizen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 16:34:42 PDT 2018


bnieuwenhuizen added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:3452
+    // The case of Width == 0 is handled above, which makes this tranformation
+    // safe.  If Width == 0, then the ashr and lshr instructions become posion
+    // value since the shift amount would be equal to the bit size.
----------------
Small nit in this comment and the commit title/message: posion -> poison?


Repository:
  rL LLVM

https://reviews.llvm.org/D53739





More information about the llvm-commits mailing list