[PATCH] D53365: [Codegen] - Implement basic .debug_loclists section emission (DWARF5).

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/CodeGen/X86/debug-loclists.ll:26-45
+; ASM-NEXT:  .short 5                                                     # Version
+; ASM-NEXT:  .byte 8                                                      # Address size
+; ASM-NEXT:  .byte 0                                                      # Segment selector size
+; ASM-NEXT:  .long 0                                                      # Offset entry count
+; ASM-NEXT: .Lloclists_table_base0:
+; ASM-NEXT: .Ldebug_loc0:
+; ASM-NEXT:  .byte 4                                                      # DW_LLE_offset_pair
----------------
dblaikie wrote:
> Maybe trim some of the whitespace from between the assembly and the comments so it's easier to read on a narrower screen? (I'd probably bring it in as close as possible while still keeping it vertically aligned)
Yeah, I am also was not happy to do that. Problem is on the line 24. Had to add spaces to keep the
vertical-align with "# Length".
I guess I'll just remove that single comment and trim the spaces then.


https://reviews.llvm.org/D53365