[PATCH] D53620: [WebAssembly] Error out when block/loop markers mismatch

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 14:55:31 PDT 2018


aheejin added a comment.

Even `llvm-mc` has to parse something (asm or obj file) before printing, so I think it makes sense to do the error checking on the parser. And also it seems methods in AsmParser return `Error` token to signal an error has occurred during parsing, so it seems to provide more infrastructure as well. I'll file a bug on that, thanks.

Then can land this as is?


Repository:
  rL LLVM

https://reviews.llvm.org/D53620





More information about the llvm-commits mailing list