[PATCH] D53727: Only call FlushFileBuffers when writing executables

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 14:14:56 PDT 2018


ruiu added a comment.

Looks like there's a way to get a filename from a file handle on Windows (https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-getfileinformationbyhandleex).

If you use this, you can check if a file name ends with ".exe", so you don't need to pass "is executable" bit around, I guess?


Repository:
  rL LLVM

https://reviews.llvm.org/D53727





More information about the llvm-commits mailing list