[PATCH] D53729: [llvm-cov] Don't remap existing paths

[David Greene via Phabricator via llvm-commits]

greened added a comment.

This fixes some compiler-rt tests that break for us due to odd symlinks in /tmp.  I haven't figured out how to generate a reasonable test within llvm sources, as any such test uses a binary with a fixed source file path encoded into it.  The result is that the test will not fail if LLVM is built in a completely different place than were it was built when the test binary was generated since the test binary path prefix won't patch the -path-equivalence prefix.

I have successfully created a test in compiler-rt fashioned after the existing llvm-cov tests there.  This test uses clang to generate a binary during testing so that the path prefixes will match and a failure will result without this patch.

I am happy to contribute the compiler-rt testcase but that goes into a different repository and can't be applied along with this patch.  If someone can come up with a good way to write a test for this that lives within the llvm repository, I'm all ears!


Repository:
  rL LLVM

https://reviews.llvm.org/D53729