[PATCH] D53679: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE

[Volkan Keles via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL345282: [AArch64][GlobalISel] Fix the LegalityPredicate for lowerIf for G_LOAD/G_STORE (authored by volkan, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D53679?vs=171132&id=171135#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D53679

Files:
  llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp
  llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-load-v4s32.mir


Index: llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-load-v4s32.mir
===================================================================
--- llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-load-v4s32.mir
+++ llvm/trunk/test/CodeGen/AArch64/GlobalISel/legalize-load-v4s32.mir
@@ -0,0 +1,21 @@
+# RUN: not llc -march=aarch64 -o - -run-pass=legalizer -debug-only=legalizer 2>&1 %s | FileCheck %s
+# REQUIRES: asserts
+
+# CHECK: Legalize Machine IR for: load_v4s32
+# CHECK-NEXT: %{{[0-9]+}}:_(<4 x s32>) = G_LOAD %{{[0-9]+}}:_(p0)
+# CHECK-NOT: Lower
+# CHECK: unable to legalize instruction
+---
+name:            load_v4s32
+legalized:       false
+tracksRegLiveness: true
+body:             |
+  bb.1:
+    liveins: $x0
+
+    %0:_(p0) = COPY $x0
+    %1:_(<4 x s32>) = G_LOAD %0(p0) :: (load 16, align 4)
+    %2:_(s32), %3:_(s32), %4:_(s32), %5:_(s32) = G_UNMERGE_VALUES %1(<4 x s32>)
+    $w0 = COPY %5(s32)
+
+...
Index: llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp
===================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp
+++ llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp
@@ -167,7 +167,7 @@
       .unsupportedIfMemSizeNotPow2()
       // Lower any any-extending loads left into G_ANYEXT and G_LOAD
       .lowerIf([=](const LegalityQuery &Query) {
-        return Query.Types[0].getSizeInBits() != Query.MMODescrs[0].Size * 8;
+        return Query.Types[0].getSizeInBits() != Query.MMODescrs[0].Size;
       })
       .clampNumElements(0, v2s32, v2s32);
 
@@ -185,7 +185,7 @@
       .unsupportedIfMemSizeNotPow2()
       .lowerIf([=](const LegalityQuery &Query) {
         return Query.Types[0].isScalar() &&
-               Query.Types[0].getSizeInBits() != Query.MMODescrs[0].Size * 8;
+               Query.Types[0].getSizeInBits() != Query.MMODescrs[0].Size;
       })
       .clampNumElements(0, v2s32, v2s32);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53679.171135.patch
Type: text/x-patch
Size: 1925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181025/2ed40dae/attachment.bin>