[PATCH] D53620: [WebAssembly] Error out when block/loop markers mismatch

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel added a comment.

If the only path to this assert would be through code (from our backend), I would agree that asserts are the right thing. But if a user can create a .s file and assemble it with llvm-mc and then print, this should result in an error, or succeed without asserts. That, or we can guarantee in other paths that this can never happen, by making the assembler check for this, then an assert is ok again.

There are builds where assert becomes nop, so messages in there are not sufficient.


Repository:
  rL LLVM

https://reviews.llvm.org/D53620