[PATCH] D53245: Teach the DominatorTree fallback to recalculation when applying updates to speedup JT (PR37929)

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 09:01:20 PDT 2018


brzycki added a comment.

> The issue I find with cl::opt here is that this is a generic class that may not necessarily have a corresponding cpp file -- there can be multiple clients to GenericDomTreeConstruction, each with different requirements. Because of that, it's not clear to me in which translation unit one would put cl::opt for the constant in.
>  Is that a solved problem somewhere else in LLVM? I'm not familiar with using cl::opt in header files.

Fair enough. I'm more used to working on function passes that have several `cl::opt()` lines at the top of the .cpp file. If we don't have a corresponding cpp it's non-trivial to add it as a command-line argument. I too have never tried to use `cl::opt()` in a .h.


Repository:
  rL LLVM

https://reviews.llvm.org/D53245





More information about the llvm-commits mailing list