[PATCH] D53670: Revert "Teach __libcpp_is_floating_point that __fp16 and _Float16 are"

Marshall Clow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 25 07:30:55 PDT 2018


mclow.lists added a comment.

In https://reviews.llvm.org/D53670#1275107, @EricWF wrote:

> Sorry I'm late to the party, but we should just be falling back to `__is_floating_point` if we have it. Since it will always give us the answer we want. (Including for `__float128` which we don't handle ATM).


@EricWF and I discussed this privately, and I disagree.
There's lots of things in the standard library that key off of `std::is_floating_point`, and we don't support *any* of them for `__fp16` or `_Float16` or `__float128`.


Repository:
  rL LLVM

https://reviews.llvm.org/D53670





More information about the llvm-commits mailing list