[PATCH] D53552: [DAGCombine] Improve alias analysis for chain of independent stores.

Thu Oct 25 03:16:43 PDT 2018

courbet added a comment.

In https://reviews.llvm.org/D53552#1272602, @niravd wrote:

> courbet@, I think this should produce at least as good compile time as https://reviews.llvm.org/D53289. Can you verify on your testcase? If so, I move we drop https://reviews.llvm.org/D53289 (and https://reviews.llvm.org/D31068) in favor of this.

I have not had the time to look at the diff yet, but I patched it and re-ran the benchmarks. I can confirm that this fixes the compile-time performance issue as well or better as https://reviews.llvm.org/D53289:

F7451116: CM73hV4dNDz.png <https://reviews.llvm.org/F7451116>

================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19060
+    CombineTo(St, TF);
+    MadeChangeToST = true;
+
----------------
this is never used

Repository:
  rL LLVM

https://reviews.llvm.org/D53552