[PATCH] D53567: [Support] Enable color diagnostics for mintty

[Peiyuan Song via Phabricator via llvm-commits]

SquallATF added inline comments.


================
Comment at: lib/Support/Windows/Process.inc:231
 
+#if defined(__MINGW32__)
+// Hack to detect mintty, ported from vim
----------------
rnk wrote:
> This is plain old win32 API code. Why make it mingw-specific? Then clang-cl will use colors in mintty. I previously used it as my primary development environment, even for targeting MSVC. Today I use cmd, since it's improved greatly, but it's still pretty janky.
1. GetFileInformationByHandleEx will failed build on windows xp without FileExtd.lib, does llvm need support windows xp?
2. I did not want to affect MSVC users, if not necessary.


Repository:
  rL LLVM

https://reviews.llvm.org/D53567