[PATCH] D53686: [CMake] When built with LLVM, not use `-Wl,-z,defs`

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: CMakeLists.txt:378
   list(APPEND SANITIZER_COMMON_LINK_LIBS ${COMPILER_RT_BUILTINS_LIBRARY})
+  if (NOT COMPILER_RT_STANDALONE_BUILD)
+    string(REPLACE "-Wl,-z,defs" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}")
----------------
Would it make sense to do it unconditionally? If the flag isn't present it should be a no-op.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D53686